Code Quality & Reviews

Code Quality & Reviews

Firmware lives a long time on a chip that is awkward to patch. This subject is using review and lightweight quality rules so "works on my desk" does not become unmaintainable: reviewable diffs, comments that cite a risk (concurrency, undefined behaviour, missing fail-safe), and a shared bar for the team.

Starting Points

• Google Engineering Practices. Code Review.
• Team collaboration & accountability
• MISRA C or CERT C — awareness of a few rules that matter on MCUs (no unused, check returns, no unbounded recursion).

Key Points

• You open merge requests that a reviewer can understand (scope, why, how to test on hardware).
• You review for correctness, readability, and device risk, not style nits alone.
• You respond to review comments with a change or a reasoned disagreement.
• You apply at least one automated check (formatter, compiler warnings, simple static analysis).
• You treat review as part of Done, not an optional courtesy after the demo.